Fix multiple appends of '_dg' in name attribute on calling inverse() #6563

jwalaQ · 2021-06-11T22:07:48Z

Summary
Each call to a gate's inverse method appends '_dg' to the name attribute of the gate.

Details and comments

Upon running the following code,

qc = QuantumCircuit(2)
qc.cx(0,1)
qc_gate = qc.to_gate(name='qc_gate')
qc_gate_inv = qc_gate.inverse()
qc_gate_inv_inv = qc_gate_inv.inverse()

print(qc_gate.name)
print(qc_gate_inv.name)
print(qc_gate_inv_inv.name)

The output was:

circuit_name
circuit_name_dg
circuit_name_dg_dg

The output after the proposed changes is:

circuit_name
circuit_name_dg
circuit_name

If inverse() method of Gate is called multiple times, each call appended '_dg' to the end of the name attribute, i.e. 'gate_name_dg_dg'. This commit fixes it by checking if the name already contains '_dg'. If so, the '_dg' is removed from the name. If not, '_dg' is added.

jwalaQ added 2 commits June 12, 2021 02:52

Add tests and release notes.

1f94d76

jwalaQ requested a review from a team as a code owner June 11, 2021 22:07

Update bugfix-gate-inverse-name-3401093a18813ace.yaml

8e27720

ajavadia approved these changes Jun 12, 2021

View reviewed changes

ajavadia merged commit 0df56b3 into Qiskit:main Jun 12, 2021

1ucian0 mentioned this pull request Jun 12, 2021

Fix label inconsistency issue when gate inverse is called. #6404

Closed

jwalaQ deleted the fix-double-dg branch July 29, 2021 20:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix multiple appends of '_dg' in name attribute on calling inverse() #6563

Fix multiple appends of '_dg' in name attribute on calling inverse() #6563

jwalaQ commented Jun 11, 2021

Fix multiple appends of '_dg' in name attribute on calling inverse() #6563

Fix multiple appends of '_dg' in name attribute on calling inverse() #6563

Conversation

jwalaQ commented Jun 11, 2021